Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add more tests with nested parentheses. #62

Merged
merged 1 commit into from Nov 13, 2013

Conversation

Projects
None yet
2 participants
Contributor

KL-7 commented Nov 12, 2013

No description provided.

@KL-7 KL-7 referenced this pull request in twitter/twitter-text-rb Nov 12, 2013

Merged

Autolink URLs with nested parentheses. #100

@jakl jakl commented on an outdated diff Nov 13, 2013

@@ -416,10 +416,26 @@ tests:
text: "text http://msdn.com/S(deadbeef)/page.htm"
expected: "text <a href=\"http://msdn.com/S(deadbeef)/page.htm\">http://msdn.com/S(deadbeef)/page.htm</a>"
- - description: "Autolink Rdio #music url with double balanced embedded parentheses"
+ - description: "Autolink url with embedded parentheses surrounded by another pair of parentheses (without them)"
@jakl

jakl Nov 13, 2013

Contributor

(without them) might be more clear as
Autolink url with embedded parentheses without linking surrounding parentheses

@KL-7 KL-7 added a commit that referenced this pull request Nov 13, 2013

@KL-7 KL-7 Merge pull request #62 from twitter/kl_more_nested_parens_tests
Add more tests with nested parentheses.
7ebf8fa

@KL-7 KL-7 merged commit 7ebf8fa into master Nov 13, 2013

@KL-7 KL-7 deleted the kl_more_nested_parens_tests branch Nov 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment