added test cases. #9

Merged
merged 3 commits into from Oct 4, 2011

Projects

None yet

2 participants

@syo68k
syo68k commented Sep 29, 2011

No description provided.

@keitaf
Member
keitaf commented Sep 29, 2011

Thank you for the pull request!

Can you remove the test case for "http://fe3.gamepot-testdb/"? twitter-text won't consider it as a valid URL because it doesn't have TLD (e.g., .com, .net, .uk, .jp etc).

@syo68k
syo68k commented Sep 29, 2011

test case for http://fe3.gamepot-testdb/ have been removed. Please confirm.

@keitaf
Member
keitaf commented Sep 29, 2011

Thank you! One more request: Can you also add the same test case in autolink.yml? I just found out that twitter-text-js doesn't use extract.yml in its conformance test.

I'll merge this to master once twitter-text-rb and twitter-text-js are modified to pass this test case.

@syo68k
syo68k commented Sep 29, 2011

test case added to autolink.yml. Please Confirm.

@keitaf keitaf merged commit 0afbdd6 into twitter:master Oct 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment