TUIPopover issues #114

Closed
avaidyam opened this Issue May 28, 2012 · 5 comments

Comments

Projects
None yet
3 participants

Well first of all, just me being OCD, but I believe this class should be called TUIPopoverViewController. Just because its API and function mirrors the iOS one. Secondly, the real issue:

positioningView.nsWindow.screen.frame

Is incorrect, because then the window can be positioned below the dock, and below the menu bar. Instead, it's more feasible to use

positioningView.nsWindow.screen.visibleFrame

Which prevents these issues.

If we are trying to mirror UIKit (and be OCD) then it should be TUIPopoverController (no such thing as a PopoverViewController).

Do you mean it can't be positioned below the menu bar? I have a TUIPopover working alongside a statusbar item right now. This class has a number of other little issues, however, that make using it on a dock/status bar item a bit annoying. I've got a fork that I'm fixing a few things in.

Oh, alright then, I'll look at your fork. :D Thanks.

Contributor

joshaber commented May 29, 2012

Thanks @galaxas0, I incorporated that change at github/twui@5c1cad1.

As for the class name, we're not terribly interested in mirroring UIKit. In this case we're more inspired by NSPopover.

@joshaber joshaber closed this May 29, 2012

Note that change will alter how the preferredEdge should be set. ie before for a menubar dropdown you should have specified NSMaxYEdge but with this change you should specify NSMinYEdge.

Yes, there are a few side effects that I rendered up patching around. Please do expect to see more new content in my fork - I'll be pulling the best of my changes into it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment