Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Transition TUIAccessibilityElement to ARC #109

Merged
merged 2 commits into from

2 participants

@jwilling

This one set of files has been the sore thumb sticking out every time for not supporting ARC. I've quickly switched it over to ARC.

@joshaber
Collaborator

That's interesting, it looks like TUIAccessibilityElement isn't actually part of the project which is why it wasn't caught in the ARC conversion...

A couple notes. Could you annotate the accessibilityContainer property with unsafe_unretained instead of assign and re-add the trailing newline on both the files?

Thanks!

@jwilling

Actually, it looks like the class is just a stub, unless I'm missing something.

@joshaber
Collaborator

Yeah, I'll be honest. It says I wrote it but I don't really recall what it's there for :)

I'll go ahead and merge this. Thanks! :metal:

@joshaber joshaber merged commit 7bd0ff9 into twitter:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 13, 2012
  1. @jwilling
Commits on May 14, 2012
  1. @jwilling
This page is out of date. Refresh to see the latest.
View
4 lib/UIKit/TUIAccessibilityElement.h
@@ -11,11 +11,11 @@
// implements the TUIAccessibility informal protocol
@interface TUIAccessibilityElement : NSObject {
- id accessibilityContainer;
+ __unsafe_unretained id accessibilityContainer;
NSString *accessibilityLabel;
}
-@property (nonatomic, assign) id accessibilityContainer;
+@property (nonatomic, __unsafe_unretained) id accessibilityContainer;
@property (nonatomic, copy) NSString *accessibilityLabel;
@end
View
8 lib/UIKit/TUIAccessibilityElement.m
@@ -14,18 +14,10 @@ @implementation TUIAccessibilityElement
@synthesize accessibilityContainer;
@synthesize accessibilityLabel;
-- (void)dealloc
-{
- [accessibilityLabel release];
-
- [super dealloc];
-}
-
- (id)initWithAccessibilityContainer:(id)container
{
self = [super init];
if(self == nil) {
- [self release];
return nil;
}
Something went wrong with that request. Please try again.