Fixed rendered item counts for async remote typeahead. #1367

Open
wants to merge 1 commit into
from

Conversation

5 participants
@ztratar

ztratar commented Aug 27, 2015

Alleviates issue of initial suggestions being of same count as the limit and incorrectly displaying 0 results.

Previously had the server returning 5 objects and with a limit of 5, the rendered count would increase and then splice the suggestions into an empty array -- clearly not intended functionality. An item should only be counted as rendered after it is rendered.

Fixed rendered item counts for async remote typeahead. Alleviates iss…
…ue of initial suggestions being of same count as the limit and incorrectly displaying 0 results
@morontt

This comment has been minimized.

Show comment
Hide comment
@morontt

morontt Sep 3, 2015

Up! I have the same problem :(

morontt commented Sep 3, 2015

Up! I have the same problem :(

@CoreSystemDevelopment

This comment has been minimized.

Show comment
Hide comment
@CoreSystemDevelopment

CoreSystemDevelopment Sep 24, 2015

@ztratar Could you please re-submit this PR to github:corejavascript/typeahead.js. This project pretty much has been abandoned, and we continue now on a new fork. For more information please see #1320

@ztratar Could you please re-submit this PR to github:corejavascript/typeahead.js. This project pretty much has been abandoned, and we continue now on a new fork. For more information please see #1320

@jlbooker

This comment has been minimized.

Show comment
Hide comment
@jlbooker

jlbooker Oct 5, 2015

Contributor

Looks like a duplicate of #1212, has been fixed over at corejavascript/typeahead.js#8

Contributor

jlbooker commented Oct 5, 2015

Looks like a duplicate of #1212, has been fixed over at corejavascript/typeahead.js#8

@chanllen

This comment has been minimized.

Show comment
Hide comment
@chanllen

chanllen Nov 24, 2015

Solve my problem!

Solve my problem!

@zhengpd zhengpd referenced this pull request in ronzalo/spree_searchkick Jun 14, 2017

Closed

Outdated typehead.bundle.js #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment