Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

collector: Default to sample all spans in dev config #195

Closed
wants to merge 3 commits into from

2 participants

@franklinhu

No description provided.

Franklin Hu added some commits
zipkin-collector-service/config/collector-dev.scala
@@ -60,6 +62,9 @@ new ScribeZipkinCollectorConfig {
override def adaptiveSamplerConfig = new NullAdaptiveSamplerConfig {}
+ /* Default to sample everything */

Perhaps describe what the collector sampling stage does in a bit more detail here? Mention that if the collector gets too much traffic the next step would be to use the adaptive sampler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Franklin Hu Moar docs f3d0c66
@franklinhu franklinhu closed this in 193fb04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 31, 2012
  1. Default to use sample everything in dev config

    Franklin Hu authored
  2. Fix doc

    Franklin Hu authored
Commits on Nov 2, 2012
  1. Moar docs

    Franklin Hu authored
This page is out of date. Refresh to see the latest.
Showing with 13 additions and 0 deletions.
  1. +13 −0 zipkin-collector-service/config/collector-dev.scala
View
13 zipkin-collector-service/config/collector-dev.scala
@@ -13,6 +13,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
+import com.twitter.zipkin.collector.sampler.EverythingGlobalSampler
import com.twitter.zipkin.config._
import com.twitter.zipkin.config.sampler.NullAdaptiveSamplerConfig
import com.twitter.zipkin.config.zookeeper.ZooKeeperConfig
@@ -60,6 +62,17 @@ new ScribeZipkinCollectorConfig {
override def adaptiveSamplerConfig = new NullAdaptiveSamplerConfig {}
+ /**
+ * The default `globalSampler` uses a sample rate to modulate how much
+ * traffic is written out to underlying stores. We override this with
+ * the `EverythingGlobalSampler` to make the process of getting a
+ * collector up and running easier for new users.
+ *
+ * Remove this to default back to a fixed percentage-based sampling
+ * model.
+ */
+ override def globalSampler = EverythingGlobalSampler
+
def zkConfig = new ZooKeeperConfig {
servers = List("localhost:2181")
}
Something went wrong with that request. Please try again.