Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix a small bug in the UI javascript's timeUnit function #200

Closed
wants to merge 1 commit into from

2 participants

@timjr

timeUnit() needs to return a two-item list, and it shouldn't subscript numbers...

@franklinhu

Looks good to me. Thanks!

@franklinhu franklinhu referenced this pull request from a commit
Tim Daly, Jr fix a small bug in the UI javascript's timeUnit function
timeUnit() needs to return a two-item list, and it shouldn't subscript
numbers...

Author: @timjr
Fixes: #200
URL: #200
2238844
@franklinhu franklinhu closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 8, 2012
  1. timeUnit() needs to return a two-item list, and it shouldn't subscrip…

    Tim Daly, Jr authored
    …t numbers...
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 4 deletions.
  1. +1 −4 zipkin-web/src/main/resources/public/js/zipkin.js
View
5 zipkin-web/src/main/resources/public/js/zipkin.js
@@ -88,10 +88,7 @@ Zipkin.Util = (function(Zipkin) {
}
};
var timeUnit = function(value, m) {
- if (m.length == 1) {
- return value[0][1];
- }
- if (value < m[0][0]) {
+ if (m.length == 1 || value < m[0][0]) {
return [value, m[0][1]];
}
return timeUnit(value / m[0][0], m.slice(1));
Something went wrong with that request. Please try again.