Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java.lang.UnsupportedOperationException: empty.min error #442

Conversation

noslowerdna
Copy link

This pull request fixes a couple similar exceptions that we've seen when querying for nonexistent annotations.

a)

ERR [20150528-17:13:02.755] query: java.lang.UnsupportedOperationException: empty.min
ERR [20150528-17:13:02.755] query:     at scala.collection.TraversableOnce$class.min(TraversableOnce.scala:194)
ERR [20150528-17:13:02.755] query:     at scala.collection.immutable.List.min(List.scala:76)
ERR [20150528-17:13:02.755] query:     at com.twitter.zipkin.query.QueryService$$anonfun$getTraceIds$1$$anonfun$apply$9$$anonfun$apply$11$$anonfun$11.apply(QueryService.scala:161)

b)

ERR [20150625-16:42:41.283] query: java.lang.UnsupportedOperationException: empty.min
ERR [20150625-16:42:41.283] query:     at scala.collection.TraversableOnce$class.min(TraversableOnce.scala:194)
ERR [20150625-16:42:41.283] query:     at scala.collection.mutable.ArrayBuffer.min(ArrayBuffer.scala:47)
ERR [20150625-16:42:41.283] query:     at com.twitter.zipkin.query.QueryService$$anonfun$getTraceIds$1$$anonfun$apply$7.apply(QueryService.scala:147)

The exceptions can be easily reproduced by searching for a) an annotation that doesn't exist or b) two or more annotations that do not exist.

@noslowerdna
Copy link
Author

Related issue: #309

@codefromthecrypt
Copy link
Member

LGTM

@codefromthecrypt
Copy link
Member

thanks, @noslowerdna, appreciate you taking time to resolve this w/ test cases

@codefromthecrypt
Copy link
Member

closed via 6f478db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants