Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 000-retweets.md #4

Merged
merged 5 commits into from Nov 5, 2021
Merged

Create 000-retweets.md #4

merged 5 commits into from Nov 5, 2021

Conversation

igorbrigadir
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Aug 30, 2021

CLA Assistant Lite bot All contributors have signed the Developer Agreement. If the commit check is not passing, a maintainer must go the Checks tab of this PR and rerun the GitHub Action.

@igorbrigadir
Copy link
Contributor Author

I have read and agree to the Twitter Developer Agreement and Policy

@igorbrigadir
Copy link
Contributor Author

recheck

@igorbrigadir
Copy link
Contributor Author

Any response to this or any of the other proposals?

@bhalsey
Copy link
Contributor

bhalsey commented Sep 24, 2021

Thank you for your contribution! Our engineering team is reviewing your proposal and will provide feedback in a couple weeks.

@igorbrigadir
Copy link
Contributor Author

Thanks! Let me know if there's anything else you'd like me to add - this feature (knowing the exact retweet id) is essential for studying spread of information

@bhalsey
Copy link
Contributor

bhalsey commented Oct 14, 2021

Thank you for your submission. The review team is moving this proposal to a Revision needed status. This means there are a few changes we’d like you to make before we can accept the proposal.

-Adding an endpoint with the URL path of /2/tweets/:id/retweets would make it clearer this returns tweets and mitigates the id confusion mentioned.

-Can you expand on the metadata of the retweet you are interested in?

-Under Alternatives Considered, can you add mention of a couple of other products:
-The Account Activity API (AAA - available for Enterprise and Premium customers) provides retweet information for followed users. But this does not provide historical information, and event delivery is pushed via webhooks.
-We also support retweets_of_status_id: in PowerTrack (not available in v2 filtered stream). Just like AAA, it only returns real time results. This is also available via Historical PowerTrack, but it is only available to enterprise users and managed customers.

Once those changes are committed, we will accept the proposal. Please let us know as soon as your changes are made so we can accept them quickly.

As a reminder, note that an approval does not guarantee an implementation; it means we agree in principle with the proposed changes and we will consider implementing. There are circumstances that may prevent implementation (for example, further privacy and security review, a change in roadmap or priorities, or a scheduled release of functionality that supersedes this proposal).

@igorbrigadir
Copy link
Contributor Author

@bhalsey thanks! Updated! I also added a better example of the expected output.

@bhalsey
Copy link
Contributor

bhalsey commented Nov 5, 2021

Thank you for incorporating our feedback.
Good news: the review team has approved your proposal!

Note that an approval does not guarantee an implementation; it means we agree in principle with the proposed changes and we will consider implementing. There are circumstances that may prevent implementation (for example, further privacy and security review, a change in roadmap or priorities, or a scheduled release of functionality that supersedes this proposal).

We’re very happy to see your contribution shaping the Twitter API, and we are grateful for the time and effort you put in authoring a proposal.

Thank you!

@bhalsey bhalsey merged commit 1476d2f into twitterdev:main Nov 5, 2021
@igorbrigadir
Copy link
Contributor Author

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants