Adds support for Audience Intelligence #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanshishido
approved these changes
Mar 15, 2018
twitter_ads/audience.py
Outdated
|
|
||
| PROPERTIES = {} | ||
|
|
||
| RESOURCE_BASE = '/3/accounts/{account_id}/audience_intelligence/' |
There was a problem hiding this comment.
Consider using API_VERSION here
| "audience_definition": self.audience_definition, | ||
| "targeting_inputs": self.targeting_inputs | ||
| } | ||
| return self.__get(account=self.account, client=self.account.client, params=json.dumps(body)) |
There was a problem hiding this comment.
Do we need to use json.dumps here? If body is a dict, it's my understanding that it should work.
There was a problem hiding this comment.
yep, i thought so too but it turns out these are all stored as "property" objects, so i had to convert them to JSON to avoid this:
twitter_ads.error.BadRequest: <BadRequest object at 0x10d69c050 code=400 details=[{u'message': u'The JSON string format is invalid', u'code': u'INVALID'}]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.