Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[bug] resolving issue with boolean values in #to_params #44
Conversation
brblck
added some commits
Nov 16, 2015
brblck
added
the
bug
label
Nov 16, 2015
brblck
self-assigned this
Nov 16, 2015
pushed a commit
that referenced
this pull request
Nov 16, 2015
brblck
merged commit 8d5a046
into
twitterdev:master
Nov 16, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
brblck
deleted the
brblck:boolean-fix
branch
Nov 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brblck commentedNov 16, 2015
Resolves an issue where
DSL::to_paramswas handling boolean values incorrectly.Example:
Expected Result:
{ paused: false }Actual Result:
{ paused: true }