Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working correctly with the global_roles plugin #3

Open
ghost opened this issue Aug 10, 2018 · 14 comments

Comments

Projects
None yet
2 participants
@ghost
Copy link

commented Aug 10, 2018

Hello, @two-pack

I don't see Rules tab at Administration -> Groups -> My group :-( after plugin was installed.

@two-pack two-pack self-assigned this Aug 11, 2018

@two-pack

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2018

Thank you for reporting issue :)
But I cannot reproduce it.
I check Redmine 3.4.6 and latest the plugin, and I can see following Rules tab.
screenshot_on_3 4 6

Please check followings:

  1. Check again install instruction,
    https://github.com/two-pack/redmine_auto_assign_group#installation
  2. Is succeed install this plugin?
    Check Administration -> Plugins.
  3. Cloud you show your environment like /admin/info ?

@two-pack two-pack added this to the 0.1.1 milestone Aug 11, 2018

@two-pack

This comment has been minimized.

Copy link
Owner

commented Sep 24, 2018

More information for this issue?
I close this issue if no more information by the end of September.

@marvinwener

This comment has been minimized.

Copy link

commented Nov 28, 2018

I have the same issue on Redmine 3.4.5. I'm using postgres as database. I do have other plugins which could interfere. I'll try to do some tests.

@marvinwener

This comment has been minimized.

Copy link

commented Nov 29, 2018

Some logging:

Processing by WelcomeController#index as HTML
Current user: admin (id=1)
Deface: [ERROR] The original source for 'add-body-header' has changed, this override should be reviewed to ensure it's still valid.
Rendered plugins/additionals/app/views/welcome/_overview_right.html.slim (7.1ms)
Rendered welcome/index.html.erb within layouts/base (145.6ms)
Rendered plugins/a_common_libs/app/views/hooks/a_common_libs/_html_head.html.erb (15.4ms)
Rendered plugins/bestest_timer/app/views/bestest_timer/_bestest_timer_partial.html.erb (11.1ms)
Rendered plugins/extra_queries/app/views/extra_queries/hooks/_html_head.html.erb (0.8ms)
Rendered plugins/global_roles/app/views/hooks/global_roles/_head.html.erb (0.7ms)
Rendered plugins/rm_user_mentions/app/views/hooks/rum/_head.html.erb (3.2ms)
Rendered inline template (0.6ms)
Rendered plugins/additionals/app/views/additionals/_html_head.html.slim (25.3ms)
Rendered plugins/sidebar_hide/app/views/sidebar/_hideButton_partial.html.erb (0.3ms)
Rendered plugins/additionals/app/views/additionals/_content.html.slim (21.8ms)
Rendered plugins/global_roles/app/views/hooks/global_roles/_view_layouts_base_body_bottom.html.erb (0.4ms)
Rendered plugins/additionals/app/views/additionals/_body_bottom.html.slim (6.2ms)

@two-pack

This comment has been minimized.

Copy link
Owner

commented Nov 29, 2018

@marvinwener

Thank You for reporting.
Please check followings:

  1. Check again install instruction,
    https://github.com/two-pack/redmine_auto_assign_group#installation
  2. Is succeed install this plugin?
    Check Administration -> Plugins.
  3. Cloud you show your environment like /admin/info ?
@marvinwener

This comment has been minimized.

Copy link

commented Nov 29, 2018

@two-pack I managed to get the plugin workin on a clean installation. I will gradually add the other plugins to see what is causing the incompatibility

@marvinwener

This comment has been minimized.

Copy link

commented Nov 29, 2018

@two-pack Your plugin seems to not be compatible in combination with the global_roles plugins

Environment:
  Redmine version                3.4.6.stable
  Ruby version                   2.3.1-p112 (2016-04-26) [i386-linux-gnu]
  Rails version                  4.2.8
  Environment                    production
  Database adapter               PostgreSQL
SCM:
  Filesystem                     
Redmine plugins:
  a_common_libs                  2.4.0
  global_roles                   2.2.1
  redmine_auto_assign_group      0.1.0
  redmine_issue_tabs             1.3.0
  redmine_tags                   3.2.2
  sidebar_hide                   0.0.8
@two-pack

This comment has been minimized.

Copy link
Owner

commented Nov 29, 2018

@marvinwener Thanks! I'll check it 😁

@two-pack

This comment has been minimized.

Copy link
Owner

commented Nov 30, 2018

I could reproduce this problem with global_roles plugin.

@two-pack two-pack added the bug label Nov 30, 2018

@two-pack

This comment has been minimized.

Copy link
Owner

commented Dec 2, 2018

This problem is caused by a conflict of global roles and auto assign group.
I think that I cannot the problem only fixing auto assign group, need to fix global roles too.
And I don't look for workaround, I need more time to get it.

Research memo

  • Global roles plugin uses a patch with alias_method_chain for GroupHelper.
    alias_method_chain is deprecated on Rails 5, so I think it should change it.
    • Auto assign group plugin uses a patch with prepend for GroupHelper.
  • Global roles plugin uses a patch with GroupController.
    This patch changes not to call group_settings_tabs with prepend like GroupsHelperPatch module.

@two-pack two-pack removed this from the 0.1.1 milestone Dec 2, 2018

@two-pack two-pack changed the title Not working correctly for Redmine 3.4.6 Not working correctly with the global_roles plugin Dec 26, 2018

@marvinwener

This comment has been minimized.

Copy link

commented Apr 15, 2019

@two-pack Can I fix this locally? I have another plugin that uses the same construction with the GroupController. I need both plugins, but I'm lacking the rules tab now.

@two-pack

This comment has been minimized.

Copy link
Owner

commented Apr 15, 2019

@marvinwener What another plugin do do you use?

@marvinwener

This comment has been minimized.

Copy link

commented Apr 16, 2019

@two-pack I use the Email Notifications plugin: https://github.com/jrupesh/event_notifications

@two-pack

This comment has been minimized.

Copy link
Owner

commented Apr 16, 2019

@marvinwener Sorry, I don't find how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.