-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible solution to fix the issue #96 #150
Conversation
src/utils/scrollParent.js
Outdated
@@ -27,7 +27,7 @@ export default (node) => { | |||
continue; | |||
} | |||
|
|||
if (overflowRegex.test(overflow) && overflowRegex.test(overflowX) && overflowRegex.test(overflowY)) { | |||
if (overflowRegex.test(overflow) || overflowRegex.test(overflowX) || overflowRegex.test(overflowY)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'LazyLoad Overflow should not detect an overflow container when only one of the scroll property is auto/scroll FAILED', I don't really get it, users may not want to use all of this 3 properties right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here for further information about why use &&
instead of ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. That's good to know. However, this condition breaks the example in Chrome. My chrome version is Version 63.0.3239.84 (Official Build) (64-bit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to fix it as well. Thanks for your reply.
Here is my fix for issue #96. Not sure if it would work or not.