Skip to content

Conversation

@AlexMeah
Copy link
Contributor

@AlexMeah AlexMeah commented Nov 14, 2020

Allow better styling and support for libraries like TailwindCSS by allowing the user to specify className.

It's not needed for the placeholder as you can already supply a custom component.

Allow better styling and support for libraries like TailwindCSS by allowing the user to specify `className`.

It's not need for the placeholder as you can already supply a custom component.
@elodszopos
Copy link

Please god yes, I came here exactly for this!

@povilasbaranovas
Copy link

Its really weird and restricting that you can pass class name prefix and not class name. Maybe i do not know something is there some reasoning behind it?
Styled components is the most popular CSS in JS styling solution so far and this library does not have support for them until this PR will be merged. Yes you can add one more additional wrapper, but it should not be required imo.

More info on styled component reliance on class names here:
https://styled-components.com/docs/advanced#existing-css

@ameerthehacker ameerthehacker merged commit ab61b94 into twobin:master Feb 11, 2021
@ameerthehacker
Copy link
Collaborator

@AlexMeah @elodszopos @povilasbaranovas this has been released in v3.2.0, sorry for the delay.

@spenweb
Copy link

spenweb commented Feb 27, 2021

Does anyone know the release schedule for v3.2.0's corresponding @types/react-lazyload? I am currently //@ts-ignoreing the className attribute error in my .tsx file so that I can use v3.2.0. Thank you for the great package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants