Skip to content
This repository has been archived by the owner on Dec 24, 2017. It is now read-only.

Not working when parent folder name contains a space #15

Open
dineshduggal opened this issue Apr 10, 2014 · 3 comments
Open

Not working when parent folder name contains a space #15

dineshduggal opened this issue Apr 10, 2014 · 3 comments

Comments

@dineshduggal
Copy link

On Windows 8 when I try to run grunt fontsmith I get a error message "Fatal error: spawn OK" This was quite a fauge error message. After some research I found out that due to spaces in my folder name it fails to run. When I replaced the spaces with dots it worked fine. Can you make it work with parent folders that contain spaces?

Example bad folder path:
"C:\Sites\firstname lastname\Documents\SampleApplication\SampleApplication\grunt"
Example working folder path:
"C:\Sites\firstname.lastname\Documents\SampleApplication\SampleApplication\grunt"

@twolfson
Copy link
Owner

Yep, this sounds like a regression. It looks like we made an amateur mistake of not quoting our arguments in fontsmith

https://github.com/twolfson/fontsmith/blob/0.5.0/lib/engines/icomoon-phantomjs.js#L47

This should be easily resolved by using shell-quote to wrap the arguments

https://github.com/substack/node-shell-quote

I will take care of this by the end of the weekend (or you can submit a PR for even faster resolution).

@twolfson
Copy link
Owner

This has been fixed in twolfson/fontsmith#8 and was released in 0.9.0. Thanks again for the report and fix!

@dineshduggal
Copy link
Author

Thanks for applying the fix so soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants