Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantomjs 1.9.2 engine fails during sprite generation due to use of deprecated method #33

Closed
tarcon opened this issue Sep 17, 2013 · 12 comments

Comments

@tarcon
Copy link

tarcon commented Sep 17, 2013

Fatal error: 2013-09-17 15:18:00.977 phantomjs[70790:707] * WARNING: Method userSpaceScaleFactor in class NSView is deprecated on 10.7 and later. It should not be used in new applications. Use convertRectToBacking: instead.

This is a warning in the current phantomjs version. The grunt task that uses this engine exaggerates and fails at that point.

@twolfson
Copy link
Owner

Interesting, I will take a look by the end of this weekend.

@twolfson
Copy link
Owner

Looking into this now.

@twolfson
Copy link
Owner

Alright, looks like no problems inside of phantomjssmith. It runs fine with both 1.9.1 and 1.9.2. I will look into testing 1.9.2 on grunt-spritesmith next.

@twolfson
Copy link
Owner

Added 1.9.2 to grunt-spritesmith on a separate branch. Looks like the tests are passing without any warning messages in that case as well. Can you provide me more information about your setup (e.g. OS, how you installed phantomjs, grunt version, node version)?

https://travis-ci.org/Ensighten/grunt-spritesmith/builds/11673118

@me-ascii
Copy link

me-ascii commented Oct 3, 2013

+1 also have this error

grunt-spritesmith@1.8.0
phantomjs@1.9.2
node@0.10.18

@twolfson
Copy link
Owner

twolfson commented Oct 3, 2013

@me-ascii What OS are you using?

@ingebretsen
Copy link

+1

I'm also having this issue. It only appears on my retina MBP and only when I'm not plugged into an external display (only when the retina display is in use).

grunt-spritesmith@1.8.0
phantomjs@1.9.1

Here's the specific error:

Fatal error: 2013-10-02 19:50:34.142 phantomjs[41474:707] * WARNING: Method userSpaceScaleFactor in class NSView is deprecated on 10.7 and later. It should not be used in new applications. Use convertRectToBacking: instead.

@twolfson
Copy link
Owner

twolfson commented Oct 3, 2013

@ingebretsen Awesome, thanks. I will see how far I can get tonight attempting to reproduce this.

@ingebretsen
Copy link

Note: I reverted to phantomjs 1.9.0 and the issue seems to have gone away. I had a homebrew install of phantomjs. If anyone wants to revert to a previous version using homebrew and see if that fixes the issue, I used this guide: https://coderwall.com/p/lqphzg

@twolfson
Copy link
Owner

twolfson commented Oct 3, 2013

Alright, I just attempted to reproduce on Sauce Labs and failed. I am noticing that your grunt-spritesmith is not the latest. Can you upgrade to 1.11.0 and see if the latest phantomjs works?

If it is still failing, can you clone the PhantomJS engine, install its dependencies, and run it?

git clone https://github.com/twolfson/phantomjssmith
cd phantomjssmith
npm install
npm test

https://github.com/twolfson/phantomjssmith

@twolfson
Copy link
Owner

twolfson commented Oct 7, 2013

Hey guys, good news. This seems to be a deeper problem with Qt which phantomjs is based on:

thoughtbot/capybara-webkit#483

ariya/phantomjs#11612

I think I will implement a hackish patch which ignores the first line if it contains WARNING: Method userSpaceScaleFactor

@twolfson
Copy link
Owner

twolfson commented Oct 8, 2013

Alright, this has been patched and released in the phantomjs engine (phantomjssmith) as a patch version (0.1.9). As a result, if you update your node_modules, this change should be automatically picked up and PhantomJS 1.9.2 will work. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants