New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhantomJS has crushed on task start #35

Closed
Chaptykov opened this Issue Sep 23, 2013 · 9 comments

Comments

Projects
None yet
2 participants
@Chaptykov

Chaptykov commented Sep 23, 2013

When task executes on 200+ files, it crushes like this:
2013-09-23 18 04 03

On less than 200 results all is OK
2013-09-23 18 28 16

Config:

2013-09-23 18 14 13

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Sep 23, 2013

Owner

Interesting. The test suite includes test for packing of 500 sprites so the number should not be an issue. Can you provide me further info (e.g. OS, grunt version, node version, phantomjs version, size of input images)?

Owner

twolfson commented Sep 23, 2013

Interesting. The test suite includes test for packing of 500 sprites so the number should not be an issue. Can you provide me further info (e.g. OS, grunt version, node version, phantomjs version, size of input images)?

@Chaptykov

This comment has been minimized.

Show comment
Hide comment
@Chaptykov

Chaptykov Sep 24, 2013

OS: Mac OS X Lion 10.7.5

Grunt:
2013-09-24 11 52 12

Node:
2013-09-24 11 53 14

PhantomJS:
2013-09-24 11 54 17

Input: 334 png files (106 KB)
Max size of image: 73×68 px

Chaptykov commented Sep 24, 2013

OS: Mac OS X Lion 10.7.5

Grunt:
2013-09-24 11 52 12

Node:
2013-09-24 11 53 14

PhantomJS:
2013-09-24 11 54 17

Input: 334 png files (106 KB)
Max size of image: 73×68 px

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Sep 24, 2013

Owner

Hm, nothing stands out there. Can you clone phantomjssmith and run the tests?

git clone https://github.com/twolfson/phantomjssmith
cd phantomjssmith
npm install
npm test
Owner

twolfson commented Sep 24, 2013

Hm, nothing stands out there. Can you clone phantomjssmith and run the tests?

git clone https://github.com/twolfson/phantomjssmith
cd phantomjssmith
npm install
npm test
@Chaptykov

This comment has been minimized.

Show comment
Hide comment
@Chaptykov

Chaptykov commented Sep 24, 2013

Output:
2013-09-24 12 39 47

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Sep 24, 2013

Owner

Hmm, I am surprised that has not been reported earlier. It looks like it is specific to the Mac OS. I will give you an ETA for when I can take a look in a bit.

Owner

twolfson commented Sep 24, 2013

Hmm, I am surprised that has not been reported earlier. It looks like it is specific to the Mac OS. I will give you an ETA for when I can take a look in a bit.

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Sep 24, 2013

Owner

Alright, cool. I will try taking a look now.

Owner

twolfson commented Sep 24, 2013

Alright, cool. I will try taking a look now.

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Sep 24, 2013

Owner

Awesome, I have successfully reproduced using a Sauce Labs Mac instance. I will see what I can do from here.

Owner

twolfson commented Sep 24, 2013

Awesome, I have successfully reproduced using a Sauce Labs Mac instance. I will see what I can do from here.

@Chaptykov

This comment has been minimized.

Show comment
Hide comment
@Chaptykov

Chaptykov commented Sep 24, 2013

Thanks

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Sep 24, 2013

Owner

Okay, I found and patched the issue. We were grabbing stats of too many images concurrently. I introduced a limit so we pull down 100 at a time. If you update your node modules, you should be fine.

Owner

twolfson commented Sep 24, 2013

Okay, I found and patched the issue. We were grabbing stats of too many images concurrently. I introduced a limit so we pull down 100 at a time. If you update your node modules, you should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment