Add parameter to bypass sorting #5

Closed
twolfson opened this Issue Nov 3, 2013 · 8 comments

Comments

Projects
None yet
4 participants
@twolfson
Owner

twolfson commented Nov 3, 2013

As with twolfson/spritesmith#25, it would be nice if we could bypass sorting via an option. The layout algorithm would not be as optimal but it allows for the 20% (in 80/20) to get by.

@JulienCabanes

This comment has been minimized.

Show comment
Hide comment
@JulienCabanes

JulienCabanes Nov 6, 2013

+1 for bypassing sorting
I'm using grunt-spritesmith without the CSS part, only the spriting and I need to keep the original order (some kind of PNG animation)

+1 for bypassing sorting
I'm using grunt-spritesmith without the CSS part, only the spriting and I need to keep the original order (some kind of PNG animation)

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Nov 7, 2013

Owner

I will not be able to get to this this week. I will post when I am going to take it on. In the meantime, we accept PRs =D

Owner

twolfson commented Nov 7, 2013

I will not be able to get to this this week. I will post when I am going to take it on. In the meantime, we accept PRs =D

@uberbruns

This comment has been minimized.

Show comment
Hide comment
@uberbruns

uberbruns Mar 10, 2014

+1 … Today I implemented with spritesmith a loading indicator with a CSS3-Animation similar to this one: http://cssdeck.com/labs/css-image-sprite-animations-with-steps-function

But the frames ended up in an unpredictable order. Based upon the top-down-layout I added a custom layout that sorts the assets by filename. Since this implementation relies on the filenames provided by spritesmith I hesitated to make a pull request.

Maybe the best solution really would be, that there is an option, that the layout algorithm respects the input order.

thx, Karsten

+1 … Today I implemented with spritesmith a loading indicator with a CSS3-Animation similar to this one: http://cssdeck.com/labs/css-image-sprite-animations-with-steps-function

But the frames ended up in an unpredictable order. Based upon the top-down-layout I added a custom layout that sorts the assets by filename. Since this implementation relies on the filenames provided by spritesmith I hesitated to make a pull request.

Maybe the best solution really would be, that there is an option, that the layout algorithm respects the input order.

thx, Karsten

@twolfson twolfson referenced this issue in twolfson/grunt-spritesmith Mar 12, 2014

Closed

the order is not complied #69

@bfred-it

This comment has been minimized.

Show comment
Hide comment
@bfred-it

bfred-it Apr 13, 2014

+1

Same exact situation as @JulienCabanes, the sorting was throwing me off. Why sort it at all, though? Aesthetic purposes?

In the meanwhile I had to comment out the sorting, but I wish I had not to.

+1

Same exact situation as @JulienCabanes, the sorting was throwing me off. Why sort it at all, though? Aesthetic purposes?

In the meanwhile I had to comment out the sorting, but I wish I had not to.

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Apr 13, 2014

Owner

The initial intent was consistent ordering. Also, from an abstraction perspective, if you are laying items out, you will probably want them to be sorted.

I am almost free to take this on but I will accepts PR in the mean time.

Owner

twolfson commented Apr 13, 2014

The initial intent was consistent ordering. Also, from an abstraction perspective, if you are laying items out, you will probably want them to be sorted.

I am almost free to take this on but I will accepts PR in the mean time.

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Apr 16, 2014

Owner

Attempting to take care of this tonight. We will see how far I get.

Owner

twolfson commented Apr 16, 2014

Attempting to take care of this tonight. We will see how far I get.

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Apr 16, 2014

Owner

This has been released in 2.0.0. There will probably new tests to verify this works coming in spritesmith (and more option passing in grunt-spritesmith/gulp.spritesmith).

Owner

twolfson commented Apr 16, 2014

This has been released in 2.0.0. There will probably new tests to verify this works coming in spritesmith (and more option passing in grunt-spritesmith/gulp.spritesmith).

@twolfson twolfson closed this Apr 16, 2014

@twolfson

This comment has been minimized.

Show comment
Hide comment
@twolfson

twolfson Apr 16, 2014

Owner

Alright, the higher level modules have been upgraded and now support the appropriate options (algorithmOpts).

spritesmith@0.19.0, grunt-spritesmith@1.26.0, gulp.spritesmith@0.5.0

Owner

twolfson commented Apr 16, 2014

Alright, the higher level modules have been upgraded and now support the appropriate options (algorithmOpts).

spritesmith@0.19.0, grunt-spritesmith@1.26.0, gulp.spritesmith@0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment