New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added back exit code support #91
Conversation
…e exit code but struggling
Also, fwiw -- we did sanity check that this works with the |
Guessing @rpdelaney is still in the process of moving. It's been 11 days since I wrote this though so I've forgotten everything. Going to give it a review and likely land it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This has been landed in |
In #88 and #89, we moved to
PROMPT_COMMAND
and added exit code support. In #90, we discovered we broke existingPS1
extension mechanisms due to always setting the variableThis PR moves to a hybrid where we track the items we need for exit code support via a
PROMPT_COMMAND
hook and exposes them as globalsIn this PR:
PROMPT_COMMAND
as a hook, to only expose globals forPS1
PROMPT_COMMAND
extension logicPS1
to use globals fromPROMPT_COMMAND
/cc @rpdelaney