Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce a 'central' .cs.json for cs command. #1074
Conversation
yueri
reviewed
Feb 5, 2019
| @@ -17,7 +17,8 @@ Custom defaults may be provided for all commands. | |||
| Multiple clusters are supported via configuration. | |||
|
|
|||
| In order to use the Cook CLI, you’ll need a configuration file. | |||
| `cs` looks first for a `.cs.json` file in the current directory, and then for a `.cs.json` file in your home directory. | |||
This comment has been minimized.
This comment has been minimized.
yueri
Feb 5, 2019
Author
Contributor
I'm not very happy with the wording here. Can someone think of a better way to phrase this?
This comment has been minimized.
This comment has been minimized.
dposada
Feb 5, 2019
Member
I think this wording is fine. Maybe it would help to add the "why" from your PR:
Why are we making these changes?
We want to have a default
.cs.jsonconfiguration file for all users. This allows users to roll out updates to their configurations (for instance, adding a new cluster) by only updating the default.cs.jsonfile rather than the.cs.jsonfile of all their end users.
dposada
added
cli
wip
labels
Feb 5, 2019
This comment has been minimized.
This comment has been minimized.
|
I'm still working on the integration tests. It took me a while to figure out how they were working in the first place, but I think I have an idea for adding some checks. |
yueri
force-pushed the
yueri:master
branch
from
6a393cf
to
97f1833
Feb 7, 2019
pschorf
approved these changes
Feb 7, 2019
pschorf
merged commit 8d305f9
into
twosigma:master
Feb 7, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
yueri commentedFeb 5, 2019
Changes proposed in this PR
.cs.jsonfile for the cs commandWhy are we making these changes?
We want to have a default
.cs.jsonconfiguration file for all users. This allows users to roll out updates to their configurations (for instance, adding a new cluster) by only updating the default.cs.jsonfile rather than the.cs.jsonfile of all their end users.