Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running cook executor in docker containers #1121

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@pschorf
Copy link
Contributor

commented Apr 4, 2019

Changes proposed in this PR

  • Allow jobs to run in a docker container using Cook Executor

Why are we making these changes?

This will allow jobs using containers to utilize executor-specific features like exit code and progress.

@pschorf pschorf added the wip label Apr 4, 2019

@pschorf pschorf force-pushed the pschorf:cook-executor-docker branch 2 times, most recently from 81b08d5 to 8a668cf Apr 4, 2019

@pschorf pschorf force-pushed the pschorf:cook-executor-docker branch from 91d8389 to 0e6dca0 May 7, 2019

@pschorf pschorf force-pushed the pschorf:cook-executor-docker branch from 5adbdaf to a3b8493 May 7, 2019

@pschorf pschorf requested a review from shamsimam May 7, 2019

@pschorf pschorf removed the wip label May 7, 2019

@pschorf pschorf changed the title WIP: Allow running cook executor in docker containers Allow running cook executor in docker containers May 7, 2019

(assoc :executor (assoc executor :name cook-executor-name
:source cook-executor-source
:container container))

This comment has been minimized.

Copy link
@shamsimam

shamsimam May 7, 2019

Contributor

Nitpick: formatting is off

This comment has been minimized.

Copy link
@pschorf

pschorf May 8, 2019

Author Contributor

Fixed!

@shamsimam shamsimam merged commit f73db62 into twosigma:master May 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.