Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase max priority to 16,000,000 #1230

Merged
merged 6 commits into from Oct 9, 2019

Conversation

@nsinkov
Copy link
Collaborator

commented Oct 4, 2019

Changes proposed in this PR

  • increase max job priority to 2^24

Why are we making these changes?

Some users need priority over 100 (e.g. IDs used as a priority that fit in a 2^24 namespace)

@nsinkov nsinkov requested a review from dposada Oct 4, 2019
cli/cook/subcommands/submit.py Outdated Show resolved Hide resolved
cli/cook/subcommands/submit.py Outdated Show resolved Hide resolved
integration/tests/cook/test_basic.py Outdated Show resolved Hide resolved
integration/tests/cook/test_basic.py Outdated Show resolved Hide resolved
cli/cook/subcommands/submit.py Outdated Show resolved Hide resolved
@dposada
dposada approved these changes Oct 7, 2019
cli/cook/subcommands/submit.py Outdated Show resolved Hide resolved
cli/cook/subcommands/submit.py Outdated Show resolved Hide resolved
cli/cook/subcommands/submit.py Outdated Show resolved Hide resolved
integration/tests/cook/test_basic.py Outdated Show resolved Hide resolved
@dposada dposada self-requested a review Oct 7, 2019
@dposada
dposada approved these changes Oct 7, 2019
@dposada
dposada approved these changes Oct 7, 2019
@dposada

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Needs rebasing

@nsinkov nsinkov force-pushed the nsinkov:add-support-for-priority-over-100 branch from 4be77a3 to 22d334e Oct 7, 2019
@nsinkov

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 7, 2019

@dposada rebased

@dposada

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Will merge when green

@nsinkov

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

@dposada internal green

@dposada

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Travis is red on the latest commit, do you want to get it green?

@nsinkov

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2019

@dposada all green

@dposada dposada changed the title increase max priority to 2^24 increase max priority to 16,000,000 Oct 9, 2019
@dposada dposada merged commit a158e8b into twosigma:master Oct 9, 2019
2 checks passed
2 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.