Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround bug in running with minimesos. #1300

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@scrosby
Copy link
Member

scrosby commented Nov 7, 2019

Changes proposed in this PR

  • Hardcode an earlier python image into the executor build

Why are we making these changes?

We do testing in minimesos, which is unmaintained and 2 years old.
Our cook-executor docker image is based on python. As of 6 days ago,
its been updated. It now requires a version of glibc that is too new
and unsupported in minimesos's images. Temporary fix to force a specific
python image.

Scott Crosby
We do testing in minimesos, which is unmaintained and 2 years old.
Our cook-executor docker image is based on python. As of 6 days ago,
its been updated. It now requires a version of glibc that is too new
and unsupported in minimesos's images. Temporary fix to force a specific
python image.
@scrosby scrosby requested a review from dposada Nov 7, 2019
@dposada
dposada approved these changes Nov 7, 2019
@dposada

This comment has been minimized.

Copy link
Member

dposada commented Nov 7, 2019

Will merge when green

@scrosby

This comment has been minimized.

Copy link
Member Author

scrosby commented Nov 7, 2019

Internalgreen on mesos. GKE seems flaky.

@dposada dposada merged commit 34f0adb into twosigma:master Nov 7, 2019
2 checks passed
2 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scrosby scrosby deleted the scrosby:outgoing/executor-build-downgrade branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.