Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes `process` log more clear #1312

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@dposada
Copy link
Member

dposada commented Nov 19, 2019

Changes proposed in this PR

  • making the log at the top of process more clear

Why are we making these changes?

So that you can tell from the log what each part of the log means without having to look at the code.

Examples

2019-11-18 21:40:52,700 INFO  cook.kubernetes.controller [pool-4-thread-5] - In compute cluster gke-2 , processing pod 5dd36440-8652-42ab-a816-b0a47752b831 ; expected: {:expected-state :expected/completed} , existing: {:synthesized-state {:state :pod/succeeded, :exit 0, :reason Completed}}

2019-11-18 21:40:52,787 INFO  cook.kubernetes.controller [pool-4-thread-5] - In compute cluster gke-2 , processing pod 5dd36440-8652-42ab-a816-b0a47752b831 ; expected: {:expected-state :expected/completed} , existing: {:synthesized-state {:state :missing, :reason Pod was explicitly deleted}}

2019-11-18 21:40:52,787 INFO  cook.kubernetes.controller [pool-4-thread-5] - In compute cluster gke-2 , processing pod 5dd36440-8652-42ab-a816-b0a47752b831 ; expected: nil , existing: {:synthesized-state {:state :missing, :reason Pod was explicitly deleted}}

2019-11-18 21:40:52,787 INFO  cook.kubernetes.controller [pool-4-thread-5] - In compute cluster gke-2 , processing pod 5dd36440-8652-42ab-a816-b0a47752b831 ; expected: nil , existing: {:synthesized-state {:state :missing}}
@dposada dposada added the k8s label Nov 19, 2019
@dposada dposada self-assigned this Nov 19, 2019
@dposada dposada marked this pull request as ready for review Nov 19, 2019
@dposada dposada requested a review from nsinkov Nov 19, 2019
@nsinkov nsinkov merged commit d0227e4 into twosigma:master Nov 19, 2019
2 checks passed
2 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dposada dposada deleted the dposada:process-log branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.