Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yet further spark UI polish #7535

Closed
scottdraves opened this issue Jun 15, 2018 · 1 comment
Closed

yet further spark UI polish #7535

scottdraves opened this issue Jun 15, 2018 · 1 comment
Assignees
@piorek @lmitusinski
Labels
Enhancement Widgets JS

Comments

@scottdraves
Copy link
Contributor

scottdraves commented Jun 15, 2018 •
edited

when you click start:

  1. the "start" button should become de-active. a good way to test this is with the master url "spark://1.2.3.4:5050" which will take a long time to try to connect and then error out. you should not be able to click "start" while the spinner is going.
  2. after connection succeeds, and the status display appears, the start button vanishes and is replaced by the "x" button.
  3. the rest of the form should not shift vertically.
  4. move the start/stop buttons to the right and into line with the status.

Here are mocks:

screen shot 2018-06-19 at 5 54 41 pm

screen shot 2018-06-19 at 5 54 41 pm2
lmitusinski pushed a commit that referenced this issue Jun 20, 2018
#7535 disabling sparkUI form on waiting for connection, hidding conne…
4323daa 
…ct button after success
piorek added a commit that referenced this issue Jun 20, 2018
@piorek
#7535 fix class vanishing on start button
b1cffeb
piorek added a commit that referenced this issue Jun 20, 2018
@piorek
#7535 align start button properly
b92c698
piorek added a commit that referenced this issue Jun 21, 2018
@piorek
#7535 fix tooltips error when there is no connect button, fix stop bu…
a26cd88 
…tton possitioning
@piorek
Copy link
Contributor

piorek commented Jun 21, 2018

image

scottdraves pushed a commit that referenced this issue Jun 21, 2018
@piorek @scottdraves
#7535 yet further spark UI polish (#7565)
34d39e0 
* #7535 disabling sparkUI form on waiting for connection, hidding connect button after success

* #7535 fix class vanishing on start button

* #7535 align start button properly

* #7535 fix tooltips error when there is no connect button, fix stop button possitioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piorek piorek

@lmitusinski lmitusinski

Labels
Enhancement Widgets JS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@piorek @scottdraves @MariuszJurowicz @lmitusinski