Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rebase deduction logic in pull. #698

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
None yet
2 participants
@bpeabody
Copy link
Contributor

commented Mar 6, 2019

I think there must have been a change in the way argparse handles
defaults, and where previously we were getting an undefined we are now
getting a null.

Fix rebase deduction logic in pull.
I think there must have been a change in the way argparse handles
defaults, and where previously we were getting an `undefined` we are now
getting a `null`.

@bpeabody bpeabody requested a review from jhedwardyang Mar 6, 2019

@bpeabody bpeabody merged commit 0479e22 into twosigma:master Mar 26, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bpeabody bpeabody deleted the bpeabody:fix-pull-rebase-deduction branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.