New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.7 support #90

merged 5 commits into from Sep 23, 2018


2 participants
Copy link

leifwalsh commented Aug 19, 2018

No description provided.

@leifwalsh leifwalsh added the releng label Aug 19, 2018

@leifwalsh leifwalsh self-assigned this Aug 19, 2018

@leifwalsh leifwalsh requested a review from thejunglejane Aug 19, 2018

@leifwalsh leifwalsh added this to To do in General improvements via automation Aug 19, 2018


This comment has been minimized.

Copy link
Contributor Author

leifwalsh commented Aug 20, 2018

Seems we've hit something that looks like ContinuumIO/anaconda-issues#6678. It suggests this error can be ignored, but I'm not sure. Someone suggests downgrading numpy to 1.13 helps, but only numpy 1.15 supports python 3.7.

Also, travis doesn't yet have python 3.7. I guess we should hold off on this for now (though it Works On My Machine).


This comment has been minimized.

Copy link

thejunglejane commented Aug 20, 2018

This makes me wonder: do we want to/can we filter warnings in the tests that look at stderr and stdout?

Edit: I don't actually want to do this because lil test_stderr helped us find #82.

leifwalsh added some commits Sep 22, 2018

pin `Sphinx<1.8` because `releases` requires it
If we don't do this, pipenv seems to get confused on `pipenv update`:
it first selects the latest version of Sphinx, `==1.8.1`, and then
tries to re-resolve the tree with that pinned. Only then does it
discover that `releases` wants `Sphinx<1.8`, and then it errors with
unsatisfiable dependencies.

@thejunglejane thejunglejane added this to the python3.7 milestone Sep 22, 2018

Show resolved Hide resolved marbles/core/ Outdated

@thejunglejane thejunglejane merged commit 93af385 into master Sep 23, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 11e2d15...7d21f05
codecov/project 100% remains the same compared to 11e2d15
continuous-integration/travis-ci/pr The Travis CI build passed

General improvements automation moved this from To do to Done Sep 23, 2018

@thejunglejane thejunglejane deleted the py37 branch Sep 23, 2018

@thejunglejane thejunglejane restored the py37 branch Sep 23, 2018

@thejunglejane thejunglejane deleted the py37 branch Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment