New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file access in K8s pods #445

Merged
merged 4 commits into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@DaoWen
Copy link
Contributor

DaoWen commented Sep 7, 2018

Changes proposed in this PR

Adds support for the Waiter service-instance file-browsing API, mimicking the functionality we have with Waiter-Marathon. This is achieved by adding a sidecar-app running nginx and serving the contents of the main working directory (shared between the two containers).

Why are we making these changes?

Closes #357.

@DaoWen DaoWen added the wip label Sep 7, 2018

@DaoWen DaoWen changed the title Feature/k8s file access Log file access in K8s pods Sep 7, 2018

@DaoWen DaoWen force-pushed the DaoWen:feature/k8s-file-access branch from 867604c to b8543a7 Sep 11, 2018

@DaoWen DaoWen force-pushed the DaoWen:feature/k8s-file-access branch from b8543a7 to a8337d6 Sep 12, 2018

@DaoWen DaoWen requested a review from shamsimam Sep 12, 2018

@DaoWen DaoWen removed the wip label Sep 12, 2018

;; The sidecar container is only added to Waiter-managed pods if the :port number is set in this map,
;; otherwise, the file browsing API is disabled (always returning an empty array).
:fileserver {:image "twosigma/waiter-fileserver:latest"
:port 9090

This comment has been minimized.

@shamsimam

shamsimam Sep 12, 2018

Contributor

We should add a comment specifying that this port number is should not intersect with the ports starting from pod-base-port for instances.

This comment has been minimized.

@DaoWen

DaoWen Sep 12, 2018

Contributor

Clarified.

@shamsimam shamsimam merged commit 5d07cf8 into twosigma:master Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment