Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure apps and scripts for docker image builds #705

Merged
merged 1 commit into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@DaoWen
Copy link
Contributor

commented Apr 23, 2019

Changes proposed in this PR

  • Reorganized the test-apps directory to make it more flat
  • Moved the kubernetes fileserver docker image files into test-apps
  • Refactored build-docker-images.sh builds all of our docker images
  • Always use "latest" tag for docker images (which we expect local)
  • Update integration scrips for smoother experience, both when run locally and when run in Travis.

Why are we making these changes?

We want to ensure we're always running the latest version of our code/configuration in our test containers when running in Travis, and we want to do that by always running a locally-built "latest" container image.

@DaoWen DaoWen requested a review from shamsimam Apr 23, 2019

@shamsimam

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

We spoke offline, awaiting directory layout changes.

@DaoWen DaoWen force-pushed the DaoWen:fixup/local-container-builds branch 7 times, most recently from 22a6686 to a8744f9 Apr 24, 2019

@DaoWen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Renamed the old top-level test-apps directory to containers, moved the test-apps projects into a new test-apps subdirectory, and added some READMEs. Ready for review.

@DaoWen DaoWen force-pushed the DaoWen:fixup/local-container-builds branch from a8744f9 to 4c8963f Apr 25, 2019

Restructure apps and scripts for docker image builds
- Reorganized the test-apps directory to make it more flat
- Moved the kubernetes fileserver docker image files into test-apps
- Refactored build-docker-images.sh builds all of our docker images
- Always use "latest" tag for docker images (which we expect local)
- Update integration scrips for smoother experience, both when run
  locally and when run in Travis.

@DaoWen DaoWen force-pushed the DaoWen:fixup/local-container-builds branch from 4c8963f to e7974ab Apr 25, 2019

@shamsimam shamsimam merged commit 87f5ad8 into twosigma:master Apr 25, 2019

2 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.