Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents merging PRs that are not ready #706

Merged
merged 3 commits into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@dposada
Copy link
Member

commented Apr 23, 2019

Changes proposed in this PR

  • adding mergeable.yml that prevents merging PRs that don't have the internal-green label or that do have the wip label

Why are we making these changes?

To prevent merging PRs that are works in progress or fail internal builds or tests.

@dposada dposada added wip test ci labels Apr 23, 2019

@dposada dposada self-assigned this Apr 23, 2019

@dposada dposada removed the wip label Apr 23, 2019

@dposada dposada changed the title Prevents merging PRs that are not green internally Prevents merging PRs that are not ready Apr 23, 2019

@dposada dposada requested a review from shamsimam Apr 23, 2019

@shamsimam

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Good to merge?

@dposada

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

@shamsimam yep, this is good to merge. @sradack approved.

@shamsimam shamsimam merged commit 69db924 into master Apr 24, 2019

2 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dposada dposada deleted the dposada-patch-1 branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.