Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON spec to create Kitchen service via waiter cli #736

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
2 participants
@DaoWen
Copy link
Contributor

commented May 7, 2019

Changes proposed in this PR

  • Add JSON spec to create Kitchen service via waiter cli

Why are we making these changes?

This makes it easier to test Waiter in a local dev environment by creating the Kitchen test service.

@DaoWen DaoWen requested a review from dposada May 7, 2019

@dposada
Copy link
Member

left a comment

LGTM. Should we add a line to the README pointing this file out (and how to use it)?

@DaoWen DaoWen force-pushed the DaoWen:feature/add-kitchen-json branch from f773c84 to bd3c400 May 13, 2019

@DaoWen

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@dposada - Updated the README.

@dposada dposada merged commit 33cb9d2 into twosigma:master May 13, 2019

2 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.