Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
adds integration test for clients that cancel via process exit #887
Changes proposed in this PR
Why are we making these changes?
A gRPC client exiting abruptly should also be treated as a client cancellation.
waiter logs: request identified as client error
Test state output: cancel and cancel_handler present
Script output: script exiting during cancellation
9 times, most recently
Jul 25, 2019
Jul 31, 2019
4 times, most recently
Jul 31, 2019
Aug 9, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.