Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for JWT access tokens #923

Merged
merged 22 commits into from Sep 7, 2019

Conversation

@shamsimam
Copy link
Contributor

commented Aug 14, 2019

Changes proposed in this PR

  • adds implementation of jwt authenticator
  • adds jwt authenticator settings
  • adds integration test

Why are we making these changes?

Adds support for authentication using JWT access tokens to Waiter services.

@shamsimam shamsimam added the wip label Aug 14, 2019

@shamsimam shamsimam force-pushed the jwt-access-token branch 18 times, most recently from ad2e996 to 1f95c26 Aug 15, 2019

@shamsimam shamsimam removed the wip label Aug 21, 2019

@shamsimam shamsimam changed the title WIP: Adds support for JWT access tokens adds support for JWT access tokens Aug 21, 2019

@shamsimam shamsimam requested a review from sradack Aug 21, 2019

@shamsimam

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@sradack this is ready for review. No hurry merging it though.

@shamsimam shamsimam self-assigned this Aug 21, 2019

waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/bin/ci/jwks-server-setup.sh Outdated Show resolved Hide resolved
waiter/integration/waiter/authentication_test.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/core.clj Outdated Show resolved Hide resolved
waiter/src/waiter/core.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved

@shamsimam shamsimam force-pushed the jwt-access-token branch 3 times, most recently from 4f15c06 to 77aacca Aug 21, 2019

@shamsimam
Copy link
Contributor Author

left a comment

Addressed part of the feedback

waiter/bin/ci/jwks-server-setup.sh Outdated Show resolved Hide resolved
waiter/integration/waiter/authentication_test.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved

@shamsimam shamsimam force-pushed the jwt-access-token branch from 31b9a21 to 9648d4c Aug 22, 2019

@shamsimam shamsimam force-pushed the jwt-access-token branch from 4b9e9e4 to e159b12 Aug 31, 2019

@sradack
Copy link
Contributor

left a comment

Can we pretty please avoid force pushes? Thank you.

waiter/integration/waiter/authentication_test.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/spnego.clj Show resolved Hide resolved
waiter/src/waiter/util/utils.clj Outdated Show resolved Hide resolved
waiter/config-minimal.edn Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
shamsimam added 4 commits Aug 31, 2019
addresses PR feedback
- changes info to debug
- moves request->host from utils to jwt
- renames request->host to request->realm

@shamsimam shamsimam force-pushed the jwt-access-token branch from 14a18b3 to eddfe43 Sep 1, 2019

@shamsimam shamsimam force-pushed the jwt-access-token branch from eddfe43 to 8045580 Sep 1, 2019

@shamsimam
Copy link
Contributor Author

left a comment

@sradack ready for another round of review.

waiter/config-minimal.edn Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Show resolved Hide resolved
waiter/src/waiter/auth/spnego.clj Show resolved Hide resolved
waiter/src/waiter/util/utils.clj Outdated Show resolved Hide resolved
waiter/integration/waiter/authentication_test.clj Outdated Show resolved Hide resolved
waiter/integration/waiter/authentication_test.clj Outdated Show resolved Hide resolved
waiter/integration/waiter/authentication_test.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Outdated Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Show resolved Hide resolved
waiter/src/waiter/auth/jwt.clj Show resolved Hide resolved
waiter/src/waiter/util/client_tools.clj Show resolved Hide resolved
waiter/test-files/jwt/jwks.json Show resolved Hide resolved
addresses PR feedback
- uses ring/ring-core to parse query params
- renames integration tests
- moves generate-jwt-access-token to jwt-test

@sradack sradack removed the internal-green label Sep 4, 2019

@shamsimam

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

Ready for another round of review.

@sradack
sradack approved these changes Sep 7, 2019

@sradack sradack merged commit 82dd01f into master Sep 7, 2019

2 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sradack sradack deleted the jwt-access-token branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.