Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows service description builder to contribute to component->previous-descriptor-fns #954

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@shamsimam
Copy link
Contributor

commented Sep 11, 2019

Changes proposed in this PR

  • allows service description builder to contribute to component->previous-descriptor-fns

Why are we making these changes?

We would like to allow custom description builders the ability to participate in fallback.

@shamsimam shamsimam self-assigned this Sep 11, 2019

@shamsimam shamsimam added the wip label Sep 11, 2019

@shamsimam shamsimam requested a review from nsinkov Sep 11, 2019

@shamsimam shamsimam added internal-green and removed wip labels Sep 11, 2019

@nsinkov nsinkov merged commit 3745ff0 into master Sep 11, 2019

2 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nsinkov nsinkov deleted the builder-component-previous-descriptor-fns branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.