Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables synchronization when roots mismatch but updated by same user #989

Merged
merged 4 commits into from Nov 6, 2019

Conversation

@shamsimam
Copy link
Contributor

shamsimam commented Nov 2, 2019

Changes proposed in this PR

  • enables synchronization when roots mismatch but updated by same user

Why are we making these changes?

Enables syncing tokens across clusters when they have been edited by the same user.

@shamsimam shamsimam self-assigned this Nov 2, 2019
@shamsimam shamsimam force-pushed the token-sync-diff-roots-same-user branch 3 times, most recently from c049cf1 to ece865a Nov 2, 2019
@shamsimam shamsimam force-pushed the token-sync-diff-roots-same-user branch from ece865a to c01f410 Nov 5, 2019
@shamsimam shamsimam requested review from DaoWen and dposada and removed request for DaoWen Nov 5, 2019
@dposada
dposada approved these changes Nov 6, 2019
Copy link
Member

dposada left a comment

One question

token-syncer/src/token_syncer/commands/syncer.clj Outdated Show resolved Hide resolved
Co-Authored-By: Daniel Posada <daniel.posada@gmail.com>
@shamsimam

This comment has been minimized.

Copy link
Contributor Author

shamsimam commented Nov 6, 2019

@dposada accepted suggestion, good to merge

@dposada

This comment has been minimized.

Copy link
Member

dposada commented Nov 6, 2019

Will merge when green

@dposada dposada merged commit 8ae970b into master Nov 6, 2019
2 checks passed
2 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dposada dposada deleted the token-sync-diff-roots-same-user branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.