Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the error class into the request log #992

Merged
merged 2 commits into from Dec 2, 2019
Merged

Conversation

@shamsimam
Copy link
Contributor

shamsimam commented Nov 21, 2019

Changes proposed in this PR

  • adds the error class into the request log

Why are we making these changes?

Enables classification of error responses generated by Waiter.

Example request log:

$ grep -o "waiter-error-class.*" log/request.log | cut -c-100
waiter-error-class":"java.util.concurrent.TimeoutException"}
waiter-error-class":"java.io.EOFException"}
waiter-error-class":"java.net.ConnectException"}
@shamsimam shamsimam self-assigned this Nov 21, 2019
@shamsimam shamsimam force-pushed the request-log-error-class branch from 38cad02 to fc84266 Nov 21, 2019
@shamsimam shamsimam requested a review from sradack Nov 22, 2019
@@ -66,9 +66,9 @@
- the http status code."

This comment has been minimized.

Copy link
@sradack

sradack Nov 22, 2019

Contributor

Update docstring

This comment has been minimized.

Copy link
@shamsimam

shamsimam Nov 25, 2019

Author Contributor

Updated.

@shamsimam shamsimam force-pushed the request-log-error-class branch from fc84266 to 7923a03 Nov 25, 2019
@shamsimam

This comment has been minimized.

Copy link
Contributor Author

shamsimam commented Nov 26, 2019

Build is now green, this can be merged.

@sradack sradack merged commit c0f6b09 into master Dec 2, 2019
2 checks passed
2 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sradack sradack deleted the request-log-error-class branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.