Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move slf4j-simple dependency to test #375

Merged
merged 2 commits into from Jul 4, 2019
Merged

Move slf4j-simple dependency to test #375

merged 2 commits into from Jul 4, 2019

Conversation

tsiq-karold
Copy link
Collaborator

Fixes #373

MykolaGolubyev
MykolaGolubyev approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@MykolaGolubyev MykolaGolubyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tsiq-karold tsiq-karold merged commit 5d3487c into master Jul 4, 2019
@tsiq-karold tsiq-karold deleted the slf4j-simple-to-test branch July 4, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MykolaGolubyev MykolaGolubyev MykolaGolubyev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not have a non-test dependency on slf4j-simple
2 participants
@tsiq-karold @MykolaGolubyev