Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tests produced doc-artifacts to target #417

Merged
merged 3 commits into from Aug 23, 2019

Conversation

@MykolaGolubyev
Copy link
Collaborator

commented Aug 20, 2019

closes #414


try {
def args = ['--workingDir=examples', '--config=' + configFileName,
'--docPath=' + targetClasses.resolve('doc-artifacts'),

This comment has been minimized.

Copy link
@tsiq-clemens

tsiq-clemens Aug 22, 2019

Collaborator

would this honor a docPath override?

This comment has been minimized.

Copy link
@MykolaGolubyev

MykolaGolubyev Aug 22, 2019

Author Collaborator

No, it is forcing a docPath. Command line override takes precedence.

This comment has been minimized.

Copy link
@tsiq-clemens

tsiq-clemens Aug 22, 2019

Collaborator

so you're saying it would honor a docPath override.

@@ -9,9 +9,3 @@ webtau-report-*.html
*-webtau-report.html
.webtau.cache.json
.vertx
webtau-http-groovy/doc-artifacts/*

This comment has been minimized.

Copy link
@tsiq-clemens

tsiq-clemens Aug 22, 2019

Collaborator

ability to remove these is a good sign

@MykolaGolubyev MykolaGolubyev requested a review from tsiq-clemens Aug 22, 2019

@tsiq-clemens
Copy link
Collaborator

left a comment

LGTM

@MykolaGolubyev MykolaGolubyev merged commit 4ad3019 into master Aug 23, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@MykolaGolubyev MykolaGolubyev deleted the test-artifacts-placement branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.