Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize test listeners across junit4,5 and groovy cli #457

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@MykolaGolubyev
Copy link
Collaborator

MykolaGolubyev commented Nov 21, 2019

What lead to this PR is JUnit5 output had step reporter with output like

executing http.get(...)

but there was no context what test it belonged to.

Standalone Groovy runner handles this by using StandaloneTestListener and one of the implementation was StandardConsoleTestListener.

This PR moves TestListener up to be reused across various runners. It lead to quite a few small-ish changes and renamed.

@tsiq-karold I need your help reviewing it.

@MykolaGolubyev MykolaGolubyev requested a review from tsiq-karold Nov 21, 2019
@MykolaGolubyev MykolaGolubyev merged commit f269b62 into master Nov 23, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@MykolaGolubyev MykolaGolubyev deleted the shared-test-listener branch Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.