Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesnormalize test listeners across junit4,5 and groovy cli #457
+433
−582
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MykolaGolubyev commentedNov 21, 2019
What lead to this PR is JUnit5 output had step reporter with output like
but there was no context what test it belonged to.
Standalone Groovy runner handles this by using
StandaloneTestListenerand one of the implementation wasStandardConsoleTestListener.This PR moves TestListener up to be reused across various runners. It lead to quite a few small-ish changes and renamed.
@tsiq-karold I need your help reviewing it.