New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %style relative path when using %!includeconf #71

Open
GoogleCodeExporter opened this Issue Apr 18, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 18, 2015

This problem is similar to the problem related in issue 27, issue 62 and issue 
63.

1. Use %!includeconf: myconfig/conf.t2t
2. Within myconfig/conf.t2t, use %!style: foo.css
3. The generated HTML code for the CSS is:

<LINK REL="stylesheet" TYPE="text/css" HREF="foo.css">

when it should be:

<LINK REL="stylesheet" TYPE="text/css" HREF="myconfig/foo.css">

The CSS file path must always be relative to the file where the %!style 
directive appears.

The patch made in the aforementioned issues must be improved to also handle 
%!includeconf directives. See function fix_relative_path().

Original issue reported on code.google.com by aureliojargas@gmail.com on 16 Nov 2010 at 7:35

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 18, 2015

This issue was closed by revision r490.

Original comment by aureliojargas@gmail.com on 17 Nov 2010 at 8:01

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 18, 2015

Reopening this issue.

The feature is OK, but the issue won't be closed until we have a nice test 
module for it, to make sure we won't brake this behavior in the future.

Original comment by aureliojargas@gmail.com on 17 Nov 2010 at 8:04

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 18, 2015

%!style tests were added in r517.
Still missing --style and --css-inside tests.

Original comment by aureliojargas@gmail.com on 22 Nov 2010 at 6:45

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 18, 2015

--style tests were added in r519.

Original comment by aureliojargas@gmail.com on 22 Nov 2010 at 11:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment