Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus]: Lowercase host value for metrics #302

Merged
merged 2 commits into from Dec 1, 2019

Conversation

@erbesharat
Copy link
Member

erbesharat commented Nov 30, 2019

What this PR does / why we need it:
Lowercases host value for metrics

Which issue this PR fixes:
fixes #299

@erbesharat erbesharat requested a review from stp-ip Nov 30, 2019
@deepcode-ci-bot

This comment has been minimized.

Copy link

deepcode-ci-bot bot commented Nov 30, 2019

DeepCode Report (#a66414)

DeepCode analyzed this pull request.
There are no new issues.

Copy link
Member

stp-ip left a comment

/lgtm

Couldn't we also have done this once for an incoming request? Usually hosts are never case sensitive so doing it once would be workable as well right?

@erbesharat

This comment has been minimized.

Copy link
Member Author

erbesharat commented Dec 1, 2019

Now the host gets lowercased at the beginning.

@stp-ip
stp-ip approved these changes Dec 1, 2019
@stp-ip stp-ip merged commit d9def10 into txtdirect:master Dec 1, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DeepCode Found no critical issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.