Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[prometheus]: Lowercase host value for metrics #302
Conversation
This comment has been minimized.
This comment has been minimized.
deepcode-ci-bot
bot
commented
Nov 30, 2019
•
DeepCode Report (#a66414)DeepCode analyzed this pull request. |
|
/lgtm Couldn't we also have done this once for an incoming request? Usually hosts are never case sensitive so doing it once would be workable as well right? |
This comment has been minimized.
This comment has been minimized.
|
Now the host gets lowercased at the beginning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
erbesharat commentedNov 30, 2019
What this PR does / why we need it:
Lowercases host value for metrics
Which issue this PR fixes:
fixes #299