Various fixes #110

Merged
merged 16 commits into from Jan 9, 2017

Projects

None yet

1 participant

@tyarkoni
Owner
tyarkoni commented Jan 9, 2017

This PR contains mostly minor fixes and improvements. The only (possibly) notable changes include:

  • A new EnvironmentKeyMixin class that should be mixed into any Transformer that needs to use environment variables (mostly API keys for web services). This makes it easy to check whether the transformer is .available (i.e., all required environment keys are present).

  • Default Converters for any given pair of Stim types can now be set in the config module.

  • Naming conventions have changed (yet again). Stims now do not include any historical info in the name (e.g., video frames do not include the name of the source video). The reason for this is that ExtractorResult-derived DataFrames now return a bunch of info about stimulus class, history, etc., so using the name attribute for provenance seems unnecessary and just creates very long names.

  • All Transformer classes now support a ._loggable attribute that indicates whether or not they should be logged in each Stim history. This is a bit of a kludge to account for the fact that multistep converters were screwing up the history (because they contain multiple conversion steps internally, and were then overwriting the logging history with themselves at the end). MultiStepConverter hierarchy sets _loggable to False, otherwise it's currently True for all other Transformers.

  • merge_results now returns a slightly cleaner DataFrame.

@tyarkoni tyarkoni merged commit 05c1eda into master Jan 9, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on various-fixes at 78.954%
Details
@tyarkoni tyarkoni deleted the various-fixes branch Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment