From 02c068c3ae8ec2954ea03de61d6627c555d88bff Mon Sep 17 00:00:00 2001 From: Pierre Riteau Date: Tue, 8 Sep 2009 11:53:37 +0200 Subject: [PATCH] Fix and improve qint_from_int64_test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use a long long integer constant to fix a compilation error (integer constant is too large for 'long' type). Use a better value for testing, as -1 makes the test pass even if qi->value is of type uint32_t, float or double. This was suggested by Reimar Döffinger . Also, make the test fail when qi->value is of type double or float by casting qi->value to int64_t, to avoid value being promoted to the type of qi->value. Signed-off-by: Pierre Riteau Acked-by: Luiz Capitulino Signed-off-by: Aurelien Jarno --- check-qint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check-qint.c b/check-qint.c index ae5d22f7e7e..49887bb7d9c 100644 --- a/check-qint.c +++ b/check-qint.c @@ -43,10 +43,10 @@ END_TEST START_TEST(qint_from_int64_test) { QInt *qi; - const int64_t value = 0xffffffffffffffff; + const int64_t value = 0x1234567890abcdefLL; qi = qint_from_int(value); - fail_unless(qi->value == value); + fail_unless((int64_t) qi->value == value); QDECREF(qi); }