Skip to content

Commit

Permalink
Fix for deleting objects: object path must be URL percent-encoded.
Browse files Browse the repository at this point in the history
Requests to delete individual versions were failing but the errors do not bubble up.
  • Loading branch information
montebrown committed Sep 22, 2020
1 parent 9a94ab5 commit 1595012
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/waffle/storage/google/cloud_storage.ex
Expand Up @@ -50,7 +50,7 @@ defmodule Waffle.Storage.Google.CloudStorage do
Objects.storage_objects_delete(
conn(),
bucket(definition),
path_for(definition, version, meta)
path_for(definition, version, meta) |> URI.encode_www_form()
)
end

Expand Down

0 comments on commit 1595012

Please sign in to comment.