Tyler Collier tylercollier

tylercollier commented on issue php-vcr/php-vcr#94
@tylercollier

It's cool that httpdiff has colored output, although the default looks bad to me. I prefer the standard diff format. Isn't that what phpunit uses b…

@tylercollier

Thank you both. I could have figured this out for myself. But it wasn't merely laziness on my part. I figured you took the time to write the gem, s…

@tylercollier

From the readme: A really simple addition to sidekiq web to enable a job history log Where is the log? In a file? Or is it shown on the sidekiq a…

@tylercollier
Write usage instructions
tylercollier commented on issue a85/PostmanProxy#2
@tylercollier

Ha, I didn't realize @IanDominey already identified both places. My bad.

tylercollier commented on issue a85/PostmanProxy#2
@tylercollier

I'm getting the same thing. I'm on Ubuntu 12.04. That path is in two places: here and here. Where does that cert file come from? How can I get it?

tylercollier commented on issue esvit/ng-table#468
@tylercollier

+1

@tylercollier
  • 6e62d32
    Intermediate commit; in the middle of adding FieldMismatch class
tylercollier commented on pull request php-vcr/php-vcr#111
@tylercollier

I did not finish this tonight like I said I would. I've pushed a commit solely for the sake of review. Don't bother running tests. I want to think …

tylercollier commented on issue php-vcr/php-vcr#94
@tylercollier

I like it. Perhaps a sentence before the -/+ mentioning what they represent, i.e. current request and stored request. One thing to be careful of is…

tylercollier commented on pull request php-vcr/php-vcr#111
@tylercollier

I think I understand your ideas. Putting the output in a single place is a good idea. I did it how I did before because I didn't want to "rock the …

tylercollier commented on pull request php-vcr/php-vcr#111
@tylercollier

Good find!

tylercollier commented on issue php-vcr/php-vcr#94
@tylercollier

Those are good ideas. You are correct with the example output you gave. You're right that there could be a case when all the requests match equally…

tylercollier commented on issue defunkt/fakefs#290
@tylercollier

Note that a naked open like that uses the Kernel class. Try File.open.

tylercollier commented on pull request php-vcr/php-vcr#105
@tylercollier

** The following are notes for myself ** What would happen if someone uses $http_response_header outside of the local scope but still within the s…

tylercollier commented on pull request php-vcr/php-vcr#105
@tylercollier

I think the answer is to set $http_response_header ourselves. I haven't tried this yet, but in a code transform, we'd look for e.g. file_get_contents