New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Replace Selected Items #27

Closed
luxlogica opened this Issue Oct 25, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@luxlogica
Copy link

luxlogica commented Oct 25, 2015

Day Player has excellent features, but I do miss the ability that other image plugins have to select a rectangle, and have the generated image automatically replace it - in the right location, and with the right dimensions. Having to select the artboard or a group seems counter-intuitive in comparison...

Other plugins also allow me to select more than one rectangle, and replace each one with a different, automatically generated image (at the appropriate size for that rectangle). This saves a great deal of time - no need to remember the dimensions of each rectangle, nor to call the plugin several times individually.

@tylergaw

This comment has been minimized.

Copy link
Owner

tylergaw commented Oct 29, 2015

Hey @luxlogica thanks for the feedback. I don't have the bandwidth to make modifications to the plugin right now, but pull requests are always welcome if you want to work on getting those changes in.

@luxlogica

This comment has been minimized.

Copy link

luxlogica commented Nov 12, 2015

@tylergaw I wish I could - I love your plugin - but unfortunately my programming skills do not extend to Cocoa... :-(

If it helps at all, I noticed that your plugin actually creates an new picture element on the artboard, while the other plugins seem to simply set the picture as the background fill of the selected item(s).

@tylergaw

This comment has been minimized.

Copy link
Owner

tylergaw commented Nov 21, 2015

@luxlogica ahh, what about JavaScript? If so, you're in luck. I don't know Cocoa either, what's cool is that sketch plugins use CocoaScript so they mostly behave like plain ole JavaScript with a few twists and turns thrown in. Check out the docs here https://www.sketchapp.com/support/developer/01-introduction/01.html It's super cool, that's how I was able to to this plugin.

@tylergaw

This comment has been minimized.

Copy link
Owner

tylergaw commented Dec 19, 2016

@luxlogica In the latest release, 3.0, I added a similar feature to this. https://github.com/tylergaw/day-player#creating-images-with-dimensions-and-position-of-existing-layers

I don't replace the existing layer and currently it just does one image at a time, but maybe that'll work?

@tylergaw tylergaw closed this Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment