Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Nested pushing and pulling of columns #44

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants

The .push() and .pull() methods didn't compensate for smaller parent widths when computing their margin-left values, so I added a columns parameter using the same style as the .makeColumn() function. Defaults to the @columns variable so it shouldn't break any existing implementations of .push() or .pull(). Sorry for having them in 3 different commits — I was in a rush so just edited within Github's interface :-)

Thanks for the great "framework". You may see it in some upcoming projects from New York Magazine. I'll be sure to let you know when they go live.

I just spent the last half hour: trying to figure out why my push and pulls were weird in a .row() defined div, determined the push and pull mixins needed a @columns value passed to them, came here to contribute a pull, only to find there was one from two years ago.

This should be merged into the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment