Skip to content

Updated Automatic Integration Example - #1

Closed
Kilo-Loco wants to merge 0 commit into
typealiased:release-0.6.2from
Kilo-Loco:release-0.6.2
Closed

Updated Automatic Integration Example#1
Kilo-Loco wants to merge 0 commit into
typealiased:release-0.6.2from
Kilo-Loco:release-0.6.2

Conversation

@Kilo-Loco

Copy link
Copy Markdown

The previous example for Automatic Integration was slightly confusing. Although the argument is named "targets" the arguments passed seemed as if they could be files (BirdModels.swift). The suggested update takes the approach that the user is using a single project, using the models within that project (and possibly some external target as well), and sets the destination as the default testing folder.

Comment thread README.md Outdated
--destination UnitTestTarget
--project MyProject.xcodeproj \
--targets MyProject SomeExternalTarget \
--destination MyProjectTests

@andrewchang-bird andrewchang-bird Sep 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I agree that it could be confusing since most iOS devs might not have multi-module projects. To keep the example more concrete, what do you think about making the example something similar to:

--project Bird.xcodeproj \
--targets Bird BirdManagers \
--destination BirdTests

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works! Just the fact that the naming convention is consistent across the three different arguments is much clearer than before. This is the issue I ran into last night. I was attempting to use my BirdModel file, which had a BirdModel protocol and I used that as a target.

@andrewchang-bird

Copy link
Copy Markdown
Contributor

Accidentally closed the PR. Anyway, for a simpler installation process I’m actually going to make --targets optional.

@Kilo-Loco

Copy link
Copy Markdown
Author

I was actually going to try and implement a guided process over the weekend. I need to spend some time on this since it’s been over a year since I’ve done any terminal apps and even then they were super basic. I would like to have a read line for each argument. Something like:

What project?
Bird.xcodeproj
Which targets?
Bird
What destination?
BirdTests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants