You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Turning off built-in Typescript in VSCode loses useful features #130
I can second this. I lost the ability to remove unused imports. The other thing is that if it does recommend adding an import it always seems to recommend the relative path which is not what I have in my settings
FWIW, I think the only conflict I've seen with built-in TS is the use of private scope in templates. For now I'll stick with protected as we had already been doing and leave built-in TS on.
Can you give examples of what you mean by code hinting?
The main thing we know we drop on the floor today is what the LSP refers to as "code actions," either affiliated with a completion item (like adding the needed import statement when you pick an identifier) or as standalone directions like cleaning up unused imports. If things that don't fall into that category are missing, that may be something we're unaware of or it may be a bug.
all hover-for-code-doc abilities.
This sounds like a definite bug, independent of the other things outlined here. Can you file a separate issue with an example of what's failing? (Ideally with some code that I could drop into a Glint-enabled project and see the issue live)
If anyone is interested adding support for translating the TypeScript language service's code actions (auto-importing new identifiers, removing unused imports, etc) to the LSP equivalent, I'm happy to provide what guidance I can.
Quick 👍 / 👎 : if you're a VS Code user running into this, are you 👍 leaving TS enabled alongside Glint, or 👎 doing without the TS niceties (like auto-import)?
Reacted by Alex Matchneer, Tyler Senter, Mattias Hällkvist, Alexey Kulakov, Julien Palmas, Adam Baker, Cameron Dubas, Thomas Gossmann, Leopold Hock, Falk Pauser and 1 more
Activity
dfreeman commentedon Apr 2, 2021
It looks like we're not handling completion items with associated code actions (like adding an
import) correctly.bakerac4 commentedon Apr 13, 2021
I can second this. I lost the ability to remove unused imports. The other thing is that if it does recommend adding an import it always seems to recommend the relative path which is not what I have in my settings
wagenet commentedon Apr 27, 2021
FWIW, I think the only conflict I've seen with built-in TS is the use of private scope in templates. For now I'll stick with protected as we had already been doing and leave built-in TS on.
runspired commentedon Feb 28, 2022
I lost most code-hinting and all hover-for-code-doc abilities.
dfreeman commentedon Feb 28, 2022
Can you give examples of what you mean by code hinting?
The main thing we know we drop on the floor today is what the LSP refers to as "code actions," either affiliated with a completion item (like adding the needed import statement when you pick an identifier) or as standalone directions like cleaning up unused imports. If things that don't fall into that category are missing, that may be something we're unaware of or it may be a bug.
This sounds like a definite bug, independent of the other things outlined here. Can you file a separate issue with an example of what's failing? (Ideally with some code that I could drop into a Glint-enabled project and see the issue live)
dfreeman commentedon Apr 22, 2022
If anyone is interested adding support for translating the TypeScript language service's code actions (auto-importing new identifiers, removing unused imports, etc) to the LSP equivalent, I'm happy to provide what guidance I can.
dfreeman commentedon Apr 14, 2023
Note that @chadhietala did a massive chunk of work to support general code actions in #499, which is included in recent 1.x beta releases.
We're still missing support for auto-import as part of accepting a completion item (rather than as an after-the-fact independent action), however.
NullVoxPopuli commentedon Jan 2, 2024
Anyone want to implement this?
Related: #626
machty commentedon Jan 2, 2024
Quick 👍 / 👎 : if you're a VS Code user running into this, are you 👍 leaving TS enabled alongside Glint, or 👎 doing without the TS niceties (like auto-import)?
wagenet commentedon Jan 10, 2024
@machty There's a third option here, which is that you turn it on and off as you get annoyed with one or the other 😬
wagenet commentedon Jan 10, 2024
One of the big issues with leaving TS on is that it doesn't recognize .gts files.
spuxx-dev commentedon Jan 18, 2024
I have been running both language servers in parallel. It's been the lesser evil for me.
NullVoxPopuli commentedon Jan 18, 2024
With 1.3, you should be able to disable the TS one again
NullVoxPopuli commentedon Jan 18, 2024
I think we can close this!