Skip to content

Turning off built-in Typescript in VSCode loses useful features #130

Closed

Description

@wagenet

For instance, if I type assert it no longer suggests importing from @ember/debug.

Activity

  1. dfreeman commented on Apr 2, 2021

    @dfreeman
    Contributor

    It looks like we're not handling completion items with associated code actions (like adding an import) correctly.

  2. bakerac4 commented on Apr 13, 2021

    @bakerac4

    I can second this. I lost the ability to remove unused imports. The other thing is that if it does recommend adding an import it always seems to recommend the relative path which is not what I have in my settings

  3. wagenet commented on Apr 27, 2021

    @wagenet
    ContributorAuthor

    FWIW, I think the only conflict I've seen with built-in TS is the use of private scope in templates. For now I'll stick with protected as we had already been doing and leave built-in TS on.

  4. runspired commented on Feb 28, 2022

    @runspired
    Contributor

    I lost most code-hinting and all hover-for-code-doc abilities.

  5. dfreeman commented on Feb 28, 2022

    @dfreeman
    Contributor

    I lost most code-hinting

    Can you give examples of what you mean by code hinting?

    The main thing we know we drop on the floor today is what the LSP refers to as "code actions," either affiliated with a completion item (like adding the needed import statement when you pick an identifier) or as standalone directions like cleaning up unused imports. If things that don't fall into that category are missing, that may be something we're unaware of or it may be a bug.

    all hover-for-code-doc abilities.

    This sounds like a definite bug, independent of the other things outlined here. Can you file a separate issue with an example of what's failing? (Ideally with some code that I could drop into a Glint-enabled project and see the issue live)

  6. dfreeman commented on Apr 22, 2022

    @dfreeman
    Contributor

    If anyone is interested adding support for translating the TypeScript language service's code actions (auto-importing new identifiers, removing unused imports, etc) to the LSP equivalent, I'm happy to provide what guidance I can.

  7. dfreeman commented on Apr 14, 2023

    @dfreeman
    Contributor

    Note that @chadhietala did a massive chunk of work to support general code actions in #499, which is included in recent 1.x beta releases.

    We're still missing support for auto-import as part of accepting a completion item (rather than as an after-the-fact independent action), however.

  8. NullVoxPopuli commented on Jan 2, 2024

    @NullVoxPopuli
    Contributor

    Anyone want to implement this?

    Related: #626

  9. machty commented on Jan 2, 2024

    @machty
    Contributor

    Quick 👍 / 👎 : if you're a VS Code user running into this, are you 👍 leaving TS enabled alongside Glint, or 👎 doing without the TS niceties (like auto-import)?

  10. wagenet commented on Jan 10, 2024

    @wagenet
    ContributorAuthor

    @machty There's a third option here, which is that you turn it on and off as you get annoyed with one or the other 😬

  11. wagenet commented on Jan 10, 2024

    @wagenet
    ContributorAuthor

    One of the big issues with leaving TS on is that it doesn't recognize .gts files.

  12. spuxx-dev commented on Jan 18, 2024

    @spuxx-dev

    I have been running both language servers in parallel. It's been the lesser evil for me.

  13. NullVoxPopuli commented on Jan 18, 2024

    @NullVoxPopuli
    Contributor

    With 1.3, you should be able to disable the TS one again

  14. NullVoxPopuli commented on Jan 18, 2024

    @NullVoxPopuli
    Contributor

    I think we can close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions