Enforce explicit https addresses for TLS connections #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farost
commented
Aug 4, 2025
| password = "password" | ||
| credentials = Credentials(username, password) | ||
| return TypeDB.driver(address=f"{host}:{port}", credentials=credentials, driver_options=DriverOptions()) | ||
| return TypeDB.driver(address=f"{host}:{port}", credentials=credentials, driver_options=DriverOptions(is_tls_enabled=False)) |
Member
Author
There was a problem hiding this comment.
Tests started failing without this flag. Which is good.
| error::ConnectionError, | ||
| }; | ||
|
|
||
| #[derive(Clone, Hash, PartialEq, Eq)] |
Member
Author
There was a problem hiding this comment.
I've actually just stolen a part of my code from the cluster branch.
| driver_lang: &str, | ||
| driver_version: &str, | ||
| ) -> crate::Result<(Self, Vec<DatabaseInfo>)> { | ||
| Self::validate_tls(&address, &driver_options)?; |
Member
Author
There was a problem hiding this comment.
We validate each connection (if there can be multiple) separately, which is correct.
| fn validate_tls(address: &Address, driver_options: &DriverOptions) -> crate::Result { | ||
| match driver_options.is_tls_enabled() { | ||
| true => { | ||
| if driver_options.tls_config().is_none() { |
Member
Author
There was a problem hiding this comment.
Should not happen, but the model allows it, so why not.
flyingsilverfin
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
Drivers return explicit error messages when connection addresses and TLS options are mismatched. TLS connections require addresses to have
https. Non-TLS connections require addresses not to havehttps.Implementation
Enhance
address.rsto retrieve URI schemes from the stored addresses. Before creating a single server connection in Rust, validate the addresses based on the requirements described above.